Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a list of additional arguments for minecraft #160

Closed
wants to merge 2 commits into from

Conversation

Tartilla-TAIGO
Copy link
Contributor

@Tartilla-TAIGO Tartilla-TAIGO commented Jul 9, 2024

预期目标 What does the pull request do

Allows you to add additional arguments at startup to Minecraft (by type --quickPlayMultiplayer)


PR-Codex overview

The focus of this PR is to add support for AdditionalArguments in LaunchSettings and parse them in DefaultLaunchArgumentParser.

Detailed summary

  • Added AdditionalArguments property in LaunchSettings
  • Updated DefaultLaunchArgumentParser to parse AdditionalArguments if present

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@laolarou726
Copy link
Member

Actually, you can pass all your additional arguments to AdvanceArguments instead of create another one.

@Tartilla-TAIGO
Copy link
Contributor Author

As far as I can see it is not used anywhere

@Tartilla-TAIGO
Copy link
Contributor Author

image

@laolarou726
Copy link
Member

image

hmm, pretty sure this is a bug, I'll push a fix now, close this as completed

@laolarou726 laolarou726 closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants