Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple fixes and improvements #141

Merged
merged 8 commits into from
Apr 13, 2024
Merged

multiple fixes and improvements #141

merged 8 commits into from
Apr 13, 2024

Conversation

laolarou726
Copy link
Member

@laolarou726 laolarou726 commented Apr 10, 2024

  • add support for CurseForge/Modrinth fuzzy search
  • fix resource check potential IO related exceptions
  • resource check speedup
  • update Nuget

PR-Codex overview

The PR focuses on adding nullable reference types and changing dictionary initialization to ImmutableDictionary.

Detailed summary

  • Added nullable reference types to properties
  • Changed dictionary initialization to ImmutableDictionary
  • Updated package references
  • Added new ModrinthDependencyModelComparer
  • Updated RetryHandler response handling
  • Added new properties to CurseForgeSearchCategoryModel and SearchOptions
  • Modified DefaultVersionLocator properties
  • Updated GameRules and CurseForgeAddonInfo dictionary initialization
  • Added new classes for CurseForge models
  • Updated ModrinthVersionInfo and ModrinthFileInfo classes
  • Added new method in ModrinthAPIHelper

The following files were skipped due to too many changes: ProjBobcat/ProjBobcat/Class/Helper/ModrinthAPIHelper.cs, ProjBobcat/ProjBobcat/DefaultComponent/Installer/ModPackInstaller/CurseForgeInstaller.cs, ProjBobcat/ProjBobcat/Class/Helper/CurseForgeAPIHelper.cs, ProjBobcat/ProjBobcat/DefaultComponent/DefaultResourceCompleter.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@laolarou726 laolarou726 changed the title add support for CurseForge fuzzy search add support for CurseForge/Modrinth fuzzy search Apr 10, 2024
yueyinqiu
yueyinqiu previously approved these changes Apr 10, 2024
@laolarou726 laolarou726 changed the title add support for CurseForge/Modrinth fuzzy search multiple fixes and improvements Apr 10, 2024
yueyinqiu
yueyinqiu previously approved these changes Apr 11, 2024
Copy link

sonarcloud bot commented Apr 13, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@laolarou726 laolarou726 merged commit 0111e35 into master Apr 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants