Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ambiguous Value::setRaw usage #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/value.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class PHPCPP_EXPORT Value : private HashParent
int i = 0;

// set all elements
for (auto &elem : input) setRaw(i++, elem);
for (const auto &elem : input) setRaw(i++, static_cast<(const Value&)>(elem));
}

// old visual c++ environments have no support for initializer lists
Expand All @@ -96,7 +96,7 @@ class PHPCPP_EXPORT Value : private HashParent
int i = 0;

// set all elements
for (auto &elem : value) setRaw(i++, elem);
for (const auto &elem : value) setRaw(i++, static_cast<(const Value&)>(elem));
}

// end of visual c++ check
Expand All @@ -110,7 +110,7 @@ class PHPCPP_EXPORT Value : private HashParent
Value(const std::map<std::string,T> &value) : Value(Type::Array)
{
// set all elements
for (auto &iter : value) setRaw(iter.first.c_str(), iter.first.size(), iter.second);
for (const auto &iter : value) setRaw(iter.first.c_str(), static_cast<int>(iter.first.size()), static_cast<(const Value&)>(iter.second));
}

/**
Expand Down