Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TODOs #24

Merged
merged 14 commits into from
Oct 28, 2024
Merged

fix TODOs #24

merged 14 commits into from
Oct 28, 2024

Conversation

aldevv
Copy link
Collaborator

@aldevv aldevv commented Oct 23, 2024

  • fixed bot not being set to system account and email being set to system account
  • added default port for proxy address
  • made client public and embedded teleport client
  • added auth.pem and *.pem extensions to .gitignore
  • added users cache when calling for grants

@aldevv aldevv self-assigned this Oct 23, 2024
@aldevv aldevv marked this pull request as draft October 23, 2024 16:37
@aldevv aldevv marked this pull request as ready for review October 25, 2024 21:50
Copy link
Contributor

@ggreer ggreer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a significant improvement. I only had one comment/question.

./baton-teleport --teleport-proxy-address ${{ env.TELEPORT_PROXY }} --teleport-key-file auth.pem
baton grants --entitlement ${{ env.CONNECTOR_ENTITLEMENT }} --output-format=json | jq -e ".grants | any(.principal.id.resource !=\"${{ env.CONNECTOR_PRINCIPAL }}\")"
./baton-teleport
baton grants --entitlement ${{ env.CONNECTOR_ENTITLEMENT }} --output-format=json | jq -e ".grants | any(.principal.id.resource !=\"${{ env.CONNECTOR_PRINCIPAL }}\")" || exit 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the || exit 0 here?

@aldevv aldevv merged commit 9041fbc into ggreer/cleanup Oct 28, 2024
3 checks passed
@aldevv aldevv deleted the abernal/todos branch October 28, 2024 16:24
@aldevv aldevv restored the abernal/todos branch October 28, 2024 20:57
@aldevv aldevv deleted the abernal/todos branch October 28, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants