Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: plumbing for partial resource sync #82

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

k-tiru
Copy link

@k-tiru k-tiru commented Nov 9, 2023

Do not merge.

Summary by CodeRabbit

  • New Features

    • Introduced partial synchronization capabilities for resource management.
    • Added new CLI options for refreshing specific resources by ID and type.
    • Enhanced connector functionality to support fetching resources through a new service.
    • Implemented a new ResourceFetcher interface for improved resource fetching logic.
  • Bug Fixes

    • Improved error handling within synchronization processes for unknown resource types.
  • Chores

    • Updated documentation and comments for new functionalities and methods across various packages.

@k-tiru k-tiru requested a review from jirwin as a code owner November 9, 2023 01:58
@jirwin
Copy link
Contributor

jirwin commented Jul 30, 2024

@coderabbitai summary

Copy link

coderabbitai bot commented Jul 30, 2024

Actions performed

Summary regeneration triggered.

Copy link

coderabbitai bot commented Jul 30, 2024

Walkthrough

The recent changes enhance the connector framework's capabilities by introducing resource fetching functionalities across multiple components. This includes updates to the CLI to allow resource refresh options, the addition of a resource-fetching interface, and modifications to the synchronization processes. Overall, these enhancements promote better modularity, flexibility, and usability within the system.

Changes

Files Change Summary
internal/connector/connector.go Added FetchResourceServiceClient to connectorClient, updated Run and C methods to support resource fetching.
pkg/cli/cli.go Introduced flags for refreshing resources; modified command initialization logic for handling new flags.
pkg/connectorbuilder/connectorbuilder.go Added ResourceFetcher interface; introduced FetchResource method for improved resource management.
pkg/connectorrunner/runner.go Enhanced runnerConfig with partial sync capabilities and updated NewConnectorRunner to accommodate these changes.
pkg/sync/state.go Added new operation types and updated string representation and instantiation logic for better operation handling.
pkg/sync/syncer.go Introduced partial synchronization functionality; modified Sync method to handle new sync operations.
pkg/tasks/local/syncer.go Enhanced localSyncer to support partial synchronization; added configuration options for resource IDs.
pkg/types/types.go Updated ConnectorServer and ConnectorClient interfaces to include support for fetching resources.

Sequence Diagram(s)

sequenceDiagram
    participant CLI
    participant Connector
    participant ResourceFetcher
    participant Syncer

    CLI->>Connector: invoke refresh command with flags
    Connector->>ResourceFetcher: request resource fetching
    ResourceFetcher-->>Connector: return resource data
    Connector->>Syncer: synchronize fetched resource
    Syncer-->>Connector: confirm synchronization success
    Connector-->>CLI: return success message
Loading

🐇 "In fields where data flows bright,
New features hop, a joyful sight.
With flags and fetches, swift and keen,
Our syncs now dance, a vibrant scene!
So gather 'round, let's all rejoice,
For every change brings a new voice!" 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jirwin
Copy link
Contributor

jirwin commented Jul 30, 2024

@coderabbitai summary

Copy link

coderabbitai bot commented Jul 30, 2024

Actions performed

Summary regeneration triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants