Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for optional attributes #51

Merged
merged 8 commits into from
Aug 28, 2023
Merged

Support for optional attributes #51

merged 8 commits into from
Aug 28, 2023

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Aug 26, 2023 •
edited
Loading

Purpose

Addresses #45

The credential schema can specify an attribute as optional. Add front-end support for optional attributes.

Changes

  • Support for optional attributes as specified in the credential schema.
  • Improved error reporting when fetching the credential schema from the smart contract.
  • Add a negative test scenario for intentionally providing wrongAttributes (different as specified in the credential schema) to the browser wallet.

@DOBEN DOBEN changed the title Use required and optional attributes Support for optional attributes Aug 26, 2023
abizjak
abizjak approved these changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you merge in the changes from #50 to reduce code duplication then I think this can be merged.

Good job.

test-tools/issuer-front-end/src/Main.tsx Outdated Show resolved Hide resolved
test-tools/issuer-front-end/src/Main.tsx Outdated Show resolved Hide resolved
@DOBEN
Merge pull request #50 from Concordium/required-attrs
e60c69e 
Do not require to input attributes which are not required by the schema.
@DOBEN
Address remaining comments
7dc7575
@DOBEN DOBEN merged commit 02d6897 into main Aug 28, 2023
8 checks passed
@DOBEN DOBEN deleted the use-required-and-optional-attributes branch August 28, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@shjortConcordium shjortConcordium Awaiting requested review from shjortConcordium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DOBEN @abizjak