Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change representation of byte sequences from String to Bytes resulting in representation as Data in swift #25

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

soerenbf
Copy link
Contributor

@soerenbf soerenbf commented Aug 26, 2024

Purpose

Representation of data as hex strings is good for readability only, which should not be the core of our data structures. This PR changes the representation of raw data to Bytes and consequently Data in the generated swift code in any case where hex strings were previously used.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@soerenbf soerenbf self-assigned this Aug 26, 2024
resulting in representation as `Data` in swift
@soerenbf soerenbf marked this pull request as ready for review August 26, 2024 12:50
@soerenbf soerenbf requested a review from ramakser August 26, 2024 13:05
@soerenbf soerenbf merged commit d908ff5 into main Aug 27, 2024
5 checks passed
@soerenbf soerenbf deleted the hex-strings-as-bytes branch August 27, 2024 08:07
@soerenbf soerenbf mentioned this pull request Aug 27, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants