-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Run tests on all platforms and verify build #10
Commits on Mar 13, 2024
-
CI: Run tests on all platforms
The library is not Mac/iThing specific. UniFFI supports other languages that work on all platforms. Furthermore, Swift actually supports Linux and we might want the SDK to support that platform one day. It therefore seems reasonable to avoid unknowingly adding anything that breaks Linux support in this library. Hence we should also test the Rust code on Windows and Ubuntu.
Configuration menu - View commit details
-
Copy full SHA for cbe9ba6 - Browse repository at this point
Copy the full SHA cbe9ba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 926183e - Browse repository at this point
Copy the full SHA 926183eView commit details
Commits on Mar 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dbce236 - Browse repository at this point
Copy the full SHA dbce236View commit details -
Package.swift: Import 'Foundation'
We use `ProcessInfo`, which is part of `Foundation`, to read env vars in the package spec. The package looks to be automatically imported in newer versions of Swift/macOS, but to support older ones we need to do it explicitly.
Configuration menu - View commit details
-
Copy full SHA for d28b7bb - Browse repository at this point
Copy the full SHA d28b7bbView commit details -
Name generated framework the same as package target
Rename generated framework to `ConcordiumWalletCryptoUniffi.xcframework` to match the (similarly renamed) binary target in `Package.swift`. We cannot just rename the target to match the existing generated file because that name (`ConcordiumWalletCrypto`) is already used by the library product target. This is a requirement that apparently has been lifted in newer versions of Swift/macOS, but to support older versions, we follow it.
Configuration menu - View commit details
-
Copy full SHA for 3fe1141 - Browse repository at this point
Copy the full SHA 3fe1141View commit details -
Package.swift: Downgrade swift-tools-version
Also updated changelog.
Configuration menu - View commit details
-
Copy full SHA for ba0eb6b - Browse repository at this point
Copy the full SHA ba0eb6bView commit details -
CI: Build framework for own platform only
For the purpose of verifying that the library builds on CI, there's no point in building the binary framework for all platforms, just for the build platform itself. We take into account that some ("older") runners are Intel macs while others ("newer") run on Apple Silicon.
Configuration menu - View commit details
-
Copy full SHA for 4551df4 - Browse repository at this point
Copy the full SHA 4551df4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56eb0e5 - Browse repository at this point
Copy the full SHA 56eb0e5View commit details