Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential registry #241

Merged
merged 73 commits into from
May 30, 2023
Merged

Credential registry #241

merged 73 commits into from
May 30, 2023

Conversation

annenkov
Copy link
Contributor

@annenkov annenkov commented Apr 4, 2023 •
edited
Loading

Purpose

Add an example of a credential registry smart contract

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.

@annenkov annenkov linked an issue Apr 11, 2023 that may be closed by this pull request
Credential registry #244
Closed
@annenkov
Add initial version of the registry
af1d8dd
@annenkov
Add todos; rename get_keys to get_issuer_keys
6a1c19a
@annenkov
Add basic owner authorization
16bc1d9
@annenkov
Factor out sender_is_owner
6aee7ce
@annenkov
Add revocation authorization for holder; improve arbitrary for serial…
50fb828 
…ization schema
@annenkov
Refactoring: use ensure! instead of conditionals
de2ab44
@annenkov
Change key index to u8; factor out signature based authorization; add…
6cacd62 
… authorization based on revocation keys
@annenkov
Add an entrypoint to view revocation key and nonce
adc6c51
@annenkov
Add events
03d91bd
@annenkov
Renamed get to view
73f0828
@annenkov
Batch add/remove of public keys
125a44e
@annenkov
Use MetadataUrl from CIS2
8751e12
@annenkov
Restructure CredentialData; add more tests: get_status, add/view keys…
81970d4 
…; fix NotAcivated behaviour of get_status
@annenkov
Docs for tests
23ae17d
@annenkov
Documentation
4acbe04
@annenkov
Test entrypoints; change commitments to Vec
8a0876e
@annenkov
Add credential registry to CI
ae12594
@annenkov
Fix Uuidv4 parameter
4b9b87b
@annenkov annenkov marked this pull request as ready for review April 19, 2023 19:39
limemloh
limemloh reviewed Apr 21, 2023
View reviewed changes
examples/credential-registry/Cargo.toml Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/quickcheck-test/Cargo.toml Outdated Show resolved Hide resolved
examples/reentrancy/Cargo.toml Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
limemloh
limemloh approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@annenkov
Copy link
Contributor Author

@DOBEN I added entry_point to SigningData and check whether the right entrypoint is called. It makes sense to have it as extra assurance so we don't depend on the messages having slightly different data.

abizjak
abizjak suggested changes May 19, 2023
View reviewed changes
examples/credential-registry/Cargo.toml Outdated Show resolved Hide resolved
examples/credential-registry/Cargo.toml Outdated Show resolved Hide resolved
examples/credential-registry/Cargo.toml Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
@abizjak abizjak mentioned this pull request May 19, 2023
Merged
5 tasks
abizjak and others added 5 commits May 23, 2023 14:44
@abizjak @annenkov
Misc changes (#276)
b2557de 
* Changes and simplifications.

* Address review comments.

* Fix removal of revocation keys.

* Remove issuer keys.

* Add functions for updating credential metadata, and emitting relevant events.

* Remove unused Update event, fix serialization.

* Fix signature checking.

* Remove the use of credential IDs (uuids).

* Update examples/credential-registry/src/lib.rs

* Add comments; fix holder revocation test

---------

Co-authored-by: Danil Annenkov <[email protected]>
@annenkov
Bump concordium std to 6.2, fix credential id type in schemas
ef8a2aa
@annenkov
Fix docs
f20b057
@annenkov
Update documentation; fix error for revocation key lookup
039f407
@annenkov
Change tag for Restore; add comments about event tagging
317e973
abizjak
abizjak approved these changes May 24, 2023
View reviewed changes
concordium-std/src/types.rs Show resolved Hide resolved
examples/credential-registry/Cargo.toml Outdated Show resolved Hide resolved
examples/credential-registry/src/lib.rs Outdated Show resolved Hide resolved
DOBEN
DOBEN approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great piece of work.

examples/credential-registry/src/lib.rs Show resolved Hide resolved
@annenkov annenkov merged commit 7892408 into main May 30, 2023
@annenkov annenkov deleted the credential-registry branch May 30, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@DOBEN DOBEN DOBEN approved these changes

@limemloh limemloh Awaiting requested review from limemloh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credential registry
4 participants
@annenkov @DOBEN @abizjak @limemloh