Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove register public key tab #17

Merged
merged 7 commits into from
Aug 15, 2023
Merged

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Jul 19, 2023

Purpose

addresses #Concordium/concordium-rust-smart-contracts#258

The public_key_registry was removed from the sponsored transaction smart contract because after the protocol 6 update, we can query the public key from an account within the smart contract code. As a result, the front end does not need an extra tab anymore to register public keys for the user. This PR removes this register public key tab at the front end.

In addition, a new host function check_account_signature is available in the smart contract to verify signatures. The check_account_signature uses the AccountSignatures type as input parameter so this type is also used as input parameter for the permit function now.

Changes

  • Backend:
    • Update to use the AccountSignatures type for the input parameter to the permit function.
    • Add TLS connection so we can use the internal stagenet node (which uses https). The protocol 6 is only live on stagenet at the moment.
  • Frontend:
    • Remove register public key tab.
    • Add esLinter.

@DOBEN DOBEN marked this pull request as ready for review July 19, 2023 11:59
@DOBEN DOBEN force-pushed the remove-register-public-key-tab branch from 353bbc2 to af3448e Compare July 19, 2023 12:05
@DOBEN DOBEN force-pushed the remove-register-public-key-tab branch from af3448e to c793f2a Compare July 19, 2023 12:06
@DOBEN DOBEN requested a review from abizjak August 7, 2023 10:16
sponsoredTransactions/frontend/README.md Outdated Show resolved Hide resolved
@DOBEN DOBEN merged commit b3f5e9b into main Aug 15, 2023
4 checks passed
@DOBEN DOBEN deleted the remove-register-public-key-tab branch August 15, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants