CACHEBOX-85 #resolve

Improve Lock and Double `get` from getOrSet
ColdBox · Dec 11, 2023 · cd43133 · cd43133
1 parent 0a3d6e0
commit cd43133
Showing 1 changed file with 20 additions and 11 deletions.
diff --git a/system/cache/AbstractCacheBoxProvider.cfc b/system/cache/AbstractCacheBoxProvider.cfc
@@ -394,17 +394,26 @@ component accessors=true serializable=false {
 			return target;
 		}
 
-		// produce it
-		target = arguments.produce();
-
-		// store it
-		set(
-			objectKey         = arguments.objectKey,
-			object            = target,
-			timeout           = arguments.timeout,
-			lastAccessTimeout = arguments.lastAccessTimeout,
-			extra             = arguments.extra
-		);
+		lock
+			name          ="GetOrSet.#variables.cacheID#.#arguments.objectKey#"
+			type          ="exclusive"
+			timeout       ="45"
+			throwonTimeout="true" {
+			// double production check
+			var target = getQuiet( arguments.objectKey );
+			if ( isNull( local.target ) ) {
+				// produce it
+				target = arguments.produce();
+				// store it
+				set(
+					objectKey         = arguments.objectKey,
+					object            = target,
+					timeout           = arguments.timeout,
+					lastAccessTimeout = arguments.lastAccessTimeout,
+					extra             = arguments.extra
+				);
+			}
+		}
 
 		return target;
 	}