Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/75378 fix nested list header items #90

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

sushmi21
Copy link
Contributor

This PR fixes accessibility issues in list message

Success Criteria

  • The header item in the list receives visible focus outline
  • The button in the list header gets visible focus outline
  • The focus border color of the header button is the contrasting color of the button background color
  • The header button should not be nested inside the clickable header container div.
  • When the button inside the clickable header is triggered, it should not bubble the click to the container div
  • Action button of type 'web_url' should use 'a' tag instead of the 'button' tag with 'role=link'
  • All type of action buttons should be keyboard accessible (If it is a link, then enter key press should trigger the link. If it is button, then space-bar or enter key should trigger it)
  • Phone number button should receive visible focus border on keyboard focus
  • The list should look and behave the same for mouse users.

How to test:

  • Check the list item component in the demo page.
  • Also, test it with webchat by configuring various different lists (with/ without header, with/ without buttons, without image, long subtitles etc) to see if nothing is broken.

@sushmi21 sushmi21 changed the title Feature/75378 fix nested list item header items Feature/75378 fix nested list header items Aug 23, 2024
@sushmi21 sushmi21 requested a review from kwinto August 23, 2024 12:25
@sushmi21 sushmi21 merged commit dd1c28d into main Aug 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants