Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable action buttons #14

Merged
merged 9 commits into from
Dec 8, 2023
Merged

Reusable action buttons #14

merged 9 commits into from
Dec 8, 2023

Conversation

dshire
Copy link
Member

@dshire dshire commented Dec 7, 2023

To Implement the Postback buttons on the webchat homescreen, we need to make them reusable (https://cognigy.visualstudio.com/Cognigy.AI/_workitems/edit/56145)

Please review this PR together with the related PR on the Webchat repo by, linking the package locally. (We could also review this first and release it and implement it in the other, but it should be faster to review directly imo)

@dshire dshire requested a review from fabclj December 7, 2023 09:20
@fabclj
Copy link
Contributor

fabclj commented Dec 7, 2023

The :hover on Secondary button is now taking primary color. I think after changing specificity on ActionButtons this issue appears. It would be enough to just add background-color property on src/common/ActionButtons/SingleButtons.module.css, like is already done for primary button

Screenshot from 2023-12-07 15-21-35

@fabclj
Copy link
Contributor

fabclj commented Dec 7, 2023

The downloadable Image button is now disabled.
I tested src/messages/Image/ImageThumb.tsx and looks back to work when you just get the action from useMessageContext and pass it to PrimaryButton

Screenshot from 2023-12-07 15-28-22

Copy link
Contributor

@fabclj fabclj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected, just that 2 css issues on the comments above.

@dshire
Copy link
Member Author

dshire commented Dec 7, 2023

It works as expected, just that 2 css issues on the comments above.

Thanks, fixed both

@fabclj fabclj self-requested a review December 7, 2023 16:09
fabclj
fabclj previously approved these changes Dec 7, 2023
@kwinto kwinto merged commit 58fb3d5 into main Dec 8, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants