Messages collation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabclj
reviewed
Nov 28, 2023
fabclj
reviewed
Nov 28, 2023
fabclj
reviewed
Nov 28, 2023
fabclj
reviewed
Nov 28, 2023
fabclj
reviewed
Nov 28, 2023
|
@kwinto I did functional test, and looks working to me. |
Yes, it should be independent of message type. |
fabclj
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements message collation: subsequent messages from the same source are rendered without header (if they are within a 1-minute limit from the previous message).
See #55736 in Azure for ref.
Also moved GitHub action configs to a proper directory. This should enable test pipeline in the repo after the PR is merged.
Changes necessary to test this in Webchat are already on the v3 branch.