-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Footer.js #1733
base: main
Are you sure you want to change the base?
Update Footer.js #1733
Conversation
❌ Deploy Preview for codingtrain failed. Why did it fail? →
|
add the hacktoberfest label |
Not sure why this failed, can you elaborate on the icon you've chosen and the changes you propose to make? Glad to consider it, thank you! |
@shiffman just added new twitter logo from react-icons in footer |
If @shiffman wants the change, I'd prefer if the icon came from the Font Awesome 6 set like the others, so essentially The icon is also in the Would you only change the icons and not the labels and keep calling it "Twitter"? EDIT: The build is failing because the proposed icon was only introduced in |
To be honest, I think I prefer just leaving it as is. However, I do appreciate you @YadlaMani taking the time to engage with this repo! Is there something else you would like to work on? I suggest opening an issue to propose an idea and discuss before submitting a PR. All that said, I would consider @fturmel's suggestion and change the icon (but leave the text as "Twitter." |
@shiffman is there any issue i could take upon I am willing to contribute to the repo |
upated the twitter logo