Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/e2e #414

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Dev/e2e #414

merged 7 commits into from
Oct 16, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 11, 2024

Summary

Add E2E test infrastructure.

Will affect visual aspect of the product

NO

Check before Pull Request is ready:

Closes #411

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Oct 11, 2024 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel changed the base branch from master to development October 11, 2024 14:59
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 15, 2024 12:44
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 15, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 15, 2024

Plugin build for c6e6300 is ready 🛎️!

Copy link
Contributor

@abaicus abaicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soare-Robert-Daniel Things look good from the e2e tests perspective.

Any reason we're removing the caching steps?

@Soare-Robert-Daniel
Copy link
Contributor Author

@abaicus, I took this advise Codeinwp/themeisle-sdk#240 (comment)

@abaicus
Copy link
Contributor

abaicus commented Oct 15, 2024

We're removing the yarn cache as well. I don't think that we have that many or heavy dependencies in this particular repo, but I still think caching them would be useful as a general practice.

We can maybe look into updating the action to a more recent version: https://github.com/actions/cache?tab=readme-ov-file#example-cache-workflow

Up to you if you consider the dependencies might be worth caching. Otherwise, the PR looks good.

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 16, 2024
@Soare-Robert-Daniel
Copy link
Contributor Author

@abaicus, I Did a little research and found out that setup-node has a built-in cache on top of action/cache.

This should simplify the approach https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-data

image

@abaicus
Copy link
Contributor

abaicus commented Oct 16, 2024

@Soare-Robert-Daniel Great! That's pretty neat 👍🏻

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 9538c80 into development Oct 16, 2024
5 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEV] Add E2E testing
3 participants