Fix design issues

[cristian-ungureanu]

Summary

In this PR I address the following issues:

• Remove the top header for certain steps
• Make the next button sticky
• Added missing UTM tags
• Change the look of the logo component
• Added missing box shadow for the settings sidebar
• Keep the same aspect ratio for starter site cards

Note: After discussing this with Hardeep, the loading conditions for Onboarding were changed. The onboarding doesn't check for Neve's new users anymore. In order to load, here's what it checks for:

• User can install plugins
• Starter sites are not disabled in white-label module and
• The current theme is Neve or a child theme of it and
• It's the first installation of TPC and
• The onboarding process was not finished

Test instructions

• Install and activate Neve
• Install this version of TPC and activate it
• The onboarding should start as soon as you activate TPC
• Check and see if you can find any issues with the implementation of the previously mentioned changes

Closes #288.

[pirate-bot]

Plugin build for fdea2f2 is ready 🛎️!

• Download build

[HardeepAsrani]

Looks good, left a small feedback. We can perhaps also get design team to review the changes to confirm they don't find anything miss in parallel to QA.

[cristian-ungureanu]

Hey @Codeinwp/design-team, can you have a look here and see if there are any more required changes? 🙏

[JohnPixle]

@cristian-ungureanu I tested it on a new taste instance and looks good.

I only noticed that the hover color of the buttons is a bit off (we had discussed about a % of opacity if I recall correcty).

But looking at the overall style of the wizard and the hover styles of other buttons, I think it would make sense for the blue buttons to use the dark-bg variable on hover instead of opacity. Apart from that, everything else is great.

I am referring to the hover states of these buttons:

• In theme thumbnail overlay
• where we use buttons in the sidebar steps
• final step

Thank you for taking the time to follow-through these, and for putting so much attention.
Let me know if the above make sense and If i can help in any way

[cristian-ungureanu]

Thanks, @JohnPixle! The opacity was not really an option as it would have applied to the text of the button.
When I raised the issue I was a bit fooled since I've tested the onboarding on WP 5.5 ( had another task that required that version and forgot to update )
Having the dark color as a hover is a better option and can be implemented. Thank you for having another look over it 🚀

[mghenciu]

Super nice work, Cristi 🔝 🚀

Just some things, that may be caused by my browser or intended, but I'll mention them:

• when selecting Font Families, for me the selection outline disappears (same for hover). I think it should stay on the selected Box - even when selected. Basically use the same hover and select principles as the preview on demosites.io

Screen.Recording.2023-09-29.at.15.12.34.mov

---

• the builder dropdown, ideally should close itself when clicking outside.
• maybe we shouldn't 'scream' in the penultimate screen by using exclamation sign. Use something like this (below). But it's ok to use the exclamation on the last screen, when congratulating the user.

Thank you!

[rodica-andronache]

hey @cristian-ungureanu https://demosites.io/ seems to be down now, so I need to wait for that before testing https://vertis.d.pr/i/iocG9V.

[rodica-andronache]

@cristian-ungureanu I've tested on a normal and multisite, with various users. Found some issues on multisite, but they are not related to this PR, same thing happens for the current version as well: #292. Not sure if they should be addressed now or not.

Regarding the current PR:

• Maybe when we are in the onboarding, we can disable the Color Palette Switcher from each individual starter site, as now it’s not easy to understand where you can actually change the colours and fonts for the preview https://vertis.d.pr/i/rwQzKi ? -> this thing that was previously mentioned is still happening. When you switch colors from the onboarding, the Color Palette Switcher from each individual starter site disappears, but reappears if you change the page https://vertis.d.pr/v/LrfZYQ

• A question: While in the onboarding window, when clicking on links with target=“_blank” from a starter site, you are being taken out of the onboarding window. I know that’s normal for a link with that atribute. I was just wandering if this is something that we should consider somehow. ( Like have something done from the onboarding for it to not work like that, or maybe update the starter sites to not have any external links, or not do anything about it )? https://vertis.d.pr/v/z2c3Ue

[cristian-ungureanu]

Hey @rodica-andronache, I managed to fix the first raised issue.

The second one would require some changes in the demo data exporter repo. I think we should handle it separately as it's not that important and we can live with it for now. We can open a new issue for this and @HardeepAsrani will prioritize it as he sees fit.

About the multisite issues you've mentioned, I think they are the same as you've mentioned in this PR, right? If yes, we can handle them there.

Let me know your thoughts.

[rodica-andronache]

@cristian-ungureanu I've tested the first issue and is fixed now. For the second one, I created a new issue here.

The issues I've mentioned #292 do exist in this PR and in the current version of TPC

[cristian-ungureanu]

Thank you for your awesome testing, Rodica. 🚀

If you agree, we can move this to "Ready to merge" and we'll handle everything else separately.

[rodica-andronache]

Hey @cristian-ungureanu if you feel it's easier we can move this to ready to merge, and fix everything separately, but we'll have to test it again, before actually releasing this, because I think there are still issues.

As I mentioned in the latest comment here Codeinwp/neve#4108 that issue is still not fixed with the latest commit from this PR.
Also, with that last commit on this PR, with the current version of Neve, there's another issue happening: On a multisite, when logged in as administrator ( not super admin ), with TPC installed and activated, if you activate Neve, you get "Sorry you are not allowed to access this page" https://vertis.d.pr/v/Gyg6jh

[pirate-bot]

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀