-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new starter site content #4258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have a small NIT with regards to the logo size, and maybe review the images that they are as optimised as possible while maintaining quality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@girishpanchal30 You are not using the correct icons with the proper blob background as requested and available in Figma.
For your convenience, I have exported all the icon files in the following zip file:
Marketing Agency Icons.zip
Let me know if you have questions.
@harshitarora-in I've updated icons from the zip, please recheck with build zip, thank you |
@girishpanchal30 After installing the build, I cannot see the new icons in the onboarding or even in the editor; it is still using the old ones. Please let me know if I am missing anything. https://vertis.d.pr/i/7REj6B
Site name: Reflective Flock |
@harshitarora-in I've changed is reflected in The starter site library is managed by the |
@girishpanchal30 Then please make the changes in the Also, as we are currently updating the |
@harshitarora-in this needs to be done on the demo API endpoint, @preda-bogdan can help with this, please suggest a position for it. |
@girishpanchal30 there are differences on mobile, compared to https://demosites.io/marketing-agency/?noCache=true |
Hey @rodica-andronache, The demo site is created on the Elementor plugin and Elementor has its controls to manage the responsive. @selul @harshitarora-in If you have any suggestions or solutions please share them here, so we can fix the responsive issue as well. Thank You |
@girishpanchal30 here is the gutenberg version of it https://demosites.io/marketing-agency-gb/, is the responsiveness similar ? |
@selul Yes, I've added starter site content from this https://demosites.io/marketing-agency-gb/ demo site and it looks like same. |
@girishpanchal30 @selul While creating the starter site, Mihai mentioned that this is the maximum responsiveness we can achieve with the core blocks, as we are using a complex background for the hero section (which is not completely responsive for mobile devices). |
🎉 This PR is included in version 3.8.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
I've changed the starter site content according to the new starter site(Marketing Agency).
Issue - https://github.com/Codeinwp/neve-pro-addon/issues/2823
Check before Pull Request is ready:
Closes Codeinwp/neve-pro-addon#2823