Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a second Nav_Walker for Secondary Menu #4235

Merged
merged 4 commits into from
May 31, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Apr 25, 2024

Summary

The Secondary Menu was using only the default WordPress Nav Walker. Because of this, some missing elements prevented the Mobile Sidebar from working.

Since only the primary menu could enqueue those resources, the secondary menu did not work correctly in his absence.

To fix this, I added a new class that inherits all the functionality of the Nav_Walker but enqueues only the needed resources.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

  • Follow the instructions from the issue description
  • The mobile sidebar should work only when the secondary menu is present.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2802

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Apr 25, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Apr 25, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review April 25, 2024 08:42
@pirate-bot
Copy link
Collaborator

pirate-bot commented Apr 25, 2024

Plugin build for 4232605 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Apr 25, 2024
Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can consider some E2E testing for this case, just a NIT if you have time.

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue is fixed now ✅

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 610593f into development May 31, 2024
18 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/mobile-header branch May 31, 2024 14:41
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants