Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make woo breadcrumps scrollable #4175

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 14, 2023

Summary

This property prevents long breadcrumb names from wrapping, thus creating an overflow that was inaccessible to the user.

To solve this, I made the breadcrumbs scrollable like on the reference point

Will affect visual aspect of the product

NO

Screenshots

2023-12-14_15-13-08.mp4

Test instructions

  • Have WooCommerce with some long product names
  • On Mobile, check if the breadcrumbs are scrollable.

Check before Pull Request is ready:

Closes #4112

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 14, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 14, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 14, 2023 13:15
@pirate-bot
Copy link
Collaborator

Plugin build for 388f8d7 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 14, 2023
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue is fixed now, thank you 🚀

@preda-bogdan preda-bogdan merged commit 2b2a592 into development Dec 22, 2023
39 of 40 checks passed
@preda-bogdan preda-bogdan deleted the fix/woo-breadcrumbs-compat-long-names branch December 22, 2023 14:49
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full Woocommerce Breadcrumb is not visible in mobile devices if text is too long
4 participants