Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use container full width when featured image is missing #4139

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 10, 2023

Summary

Added the case with CSS when the featured image container is missing so the text container can take the full width.

Will affect visual aspect of the product

YES

Screenshots

Before

image

After

image

Test instructions

  • Select List as the Blog layout
  • Create some posts and set featured images for some of them
  • Hide the thumbnail for the blog posts
  • Check how the posts that have a featured image look

Check before Pull Request is ready:

Closes #4138

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 13, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review November 13, 2023 11:50
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 13, 2023
@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 13, 2023

Plugin build for fb7925c is ready 🛎️!

inc/views/template_parts.php Outdated Show resolved Hide resolved
inc/views/template_parts.php Outdated Show resolved Hide resolved
inc/views/template_parts.php Outdated Show resolved Hide resolved
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue is fixed now, thank you 🚀

@preda-bogdan preda-bogdan merged commit ae14f1c into development Nov 28, 2023
15 checks passed
@preda-bogdan preda-bogdan deleted the fix/blog-width-feature-image branch November 28, 2023 09:39
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog item is aligned to left when it has a featured image but it's hidden on the blog
4 participants