Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: neve meta sidebar error on widgets.php [#4069] #4073

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Aug 16, 2023

Summary

The script where the error occurs shouldn't even be loaded there. It seems like "global $post_type" returns "page" on "widgets.php" so it loads the script. I did a separate check for "widgets.php" page and prevent the script from loading.
I also fixed the script so even if it loads there, it won't throw an error.

Will affect visual aspect of the product

NO

Test instructions

  • Go to widgets.php / customize.php and make sure the error doesn't appear anymore.
  • Go to a post type ( cpt, page, posts etc. ) single post editor and make sure the neve sidebar is still visible

Check before Pull Request is ready:

Closes #4069.

@cristian-ungureanu cristian-ungureanu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 16, 2023
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Aug 16, 2023
@pirate-bot
Copy link
Collaborator

pirate-bot commented Aug 16, 2023

Plugin build for ddef468 is ready 🛎️!

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just will be to confirm the same on Customizer

@cristian-ungureanu
Copy link
Contributor Author

Thanks, @HardeepAsrani! You were right, it was loading on customize.php too! Nice catch!

@irinelenache
Copy link
Contributor

@cristian-ungureanu The reported error is gone, thank you 🚀 The notice is still visible and one of the two console errors is still there https://vertis.d.pr/i/cizSvg

@cristian-ungureanu
Copy link
Contributor Author

Thank you, @irinelenache. It should be fine now. Sorry for this one 🙈

@irinelenache
Copy link
Contributor

@cristian-ungureanu Everything's fine now, thank you 🙏

@cristian-ungureanu cristian-ungureanu merged commit 6bda32d into development Aug 17, 2023
15 checks passed
@cristian-ungureanu cristian-ungureanu deleted the fix/error-on-widgets-page branch August 17, 2023 06:09
@cristian-ungureanu cristian-ungureanu linked an issue Aug 17, 2023 that may be closed by this pull request
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.6.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors on widgets panel
4 participants