-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: neve meta sidebar error on widgets.php [#4069] #4073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just will be to confirm the same on Customizer
Thanks, @HardeepAsrani! You were right, it was loading on customize.php too! Nice catch! |
@cristian-ungureanu The reported error is gone, thank you 🚀 The notice is still visible and one of the two console errors is still there https://vertis.d.pr/i/cizSvg |
Thank you, @irinelenache. It should be fine now. Sorry for this one 🙈 |
@cristian-ungureanu Everything's fine now, thank you 🙏 |
🎉 This PR is included in version 3.6.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
The script where the error occurs shouldn't even be loaded there. It seems like "global $post_type" returns "page" on "widgets.php" so it loads the script. I did a separate check for "widgets.php" page and prevent the script from loading.
I also fixed the script so even if it loads there, it won't throw an error.
Will affect visual aspect of the product
NO
Test instructions
Check before Pull Request is ready:
Closes #4069.