Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu dropdown aria attribute #4020 #4053

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

preda-bogdan
Copy link
Contributor

Summary

Add aria-label on the dropdown of the sidebar menu.

Will affect the visual aspect of the product

NO

Screenshots

Pic 1

image

Aria Label

image

Test instructions

  1. Create a fresh instance of Neve
  2. Import the Web Agency Starter site
  3. Check on mobile view if the sidebar dropdown (see Pic 1) has the proper aria-label (you can use Inspect element from the browser).

Check before Pull Request is ready:

Closes #4020.

@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 28, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 28, 2023
@preda-bogdan preda-bogdan linked an issue Jul 28, 2023 that may be closed by this pull request
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jul 28, 2023

Plugin build for 7b28755 is ready 🛎️!

@rodica-andronache
Copy link
Contributor

@preda-bogdan all good here 👍

@cristian-ungureanu cristian-ungureanu merged commit 71e706e into development Aug 2, 2023
16 checks passed
@cristian-ungureanu cristian-ungureanu deleted the fix/menu_dropdown_aria branch August 2, 2023 10:42
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.6.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility issue on the menu dropdown caret
5 participants