Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: about page display when using whitelabel … #4010

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

preda-bogdan
Copy link
Contributor

Summary

Hide the About page when the WhiteLabel theme name is changed.

Will affect the visual aspect of the product

NO

Screenshots

image

Test instructions

  1. Enable the WhiteLabel module
  2. Change the theme name
  3. Check that the about page is not being displayed anymore.

Check before Pull Request is ready:

Closes Codeinwp/neve-pro-addon#2539.

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Jun 21, 2023
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jun 21, 2023

Plugin build for 30ff906 is ready 🛎️!

@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jun 21, 2023
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Jun 21, 2023
@rodica-andronache
Copy link
Contributor

@preda-bogdan it's not working. The About page is now hidden even when you are not using Neve Pro at all, with just Neve

@preda-bogdan
Copy link
Contributor Author

@rodica-andronache I've solved the hook order, the issue should be solved now. Let me know if you spot any issues. Thank you!

@rodica-andronache
Copy link
Contributor

@preda-bogdan it's working well now, with the White Label. I just have a question. When using a child theme of Neve, right now, the About page, and Upgrade link are hidden https://vertis.d.pr/i/BhNQ8K. Is that on purpose?
In the current version of Neve, this does not happen

@preda-bogdan
Copy link
Contributor Author

@rodica-andronache I'm not sure how it should behave, I think it should still be there though. What do you think?

@rodica-andronache
Copy link
Contributor

@preda-bogdan I also think it should be there

@preda-bogdan preda-bogdan merged commit b4e0a4b into development Jul 12, 2023
@preda-bogdan preda-bogdan deleted the fix/about_page_whitelabel branch July 12, 2023 15:03
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.6.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants