Skip to content

Commit

Permalink
Update InnerBrowser.php: Deprecate deleteHeader in favor of `unsetH…
Browse files Browse the repository at this point in the history
…eader` (#69)
  • Loading branch information
ThomasLandauer authored Jul 29, 2024
1 parent 12dadcf commit 66f06c9
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions src/Codeception/Lib/InnerBrowser.php
Original file line number Diff line number Diff line change
Expand Up @@ -365,27 +365,35 @@ public function haveHttpHeader(string $name, string $value): void
}

/**
* Deletes the header with the passed name. Subsequent requests
* will not have the deleted header in its request.
* Unsets a HTTP header (that was originally added by [haveHttpHeader()](#haveHttpHeader)),
* so that subsequent requests will not send it anymore.
*
* Example:
* ```php
* <?php
* $I->haveHttpHeader('X-Requested-With', 'Codeception');
* $I->amOnPage('test-headers.php');
* // ...
* $I->deleteHeader('X-Requested-With');
* $I->unsetHeader('X-Requested-With');
* $I->amOnPage('some-other-page.php');
* ```
*
* @param string $name the name of the header to delete.
* @param string $name the name of the header to unset.
*/
public function deleteHeader(string $name): void
public function unsetHeader(string $name): void
{
$name = implode('-', array_map('ucfirst', explode('-', strtolower(str_replace('_', '-', $name)))));
unset($this->headers[$name]);
}

/**
* @deprecated Use [unsetHttpHeader](#unsetHttpHeader) instead
*/
public function deleteHeader(string $name): void
{
$this->unsetHttpHeader($name);
}

public function amOnPage(string $page): void
{
$this->_loadPage('GET', $page);
Expand Down

0 comments on commit 66f06c9

Please sign in to comment.