-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cass sb 8 fix connectformtypes #2963
Open
dreamwasp
wants to merge
8
commits into
storybook-8-new-styleguide
Choose a base branch
from
cass-sb-8-fix-connectformtypes
base: storybook-8-new-styleguide
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cass sb 8 fix connectformtypes #2963
dreamwasp
wants to merge
8
commits into
storybook-8-new-styleguide
from
cass-sb-8-fix-connectformtypes
+87
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 94acefc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
🚀 Styleguide deploy preview ready! |
📬Published Alpha Packages:[email protected] |
dreamwasp
requested review from
timjenkins,
BandanaKM,
aresnik11 and
jakemhiller
and removed request for
a team
November 1, 2024 13:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Makes a couple changes to ConnectedForm - I think some of the pakacge bumps require stricter type safety
Testing Instructions
All tests + builds are now passing locally, the remaining test failures are due to the other act errors. See all tests passing in the monorepo PR