fix(Markdown): filter styles from video #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamwasp
changed the title
dreamwasp
requested review from
BandanaKM,
LinKCoding,
jakemhiller and
aresnik11
jakemhiller
reviewed
Oct 15, 2024
jakemhiller
reviewed
Oct 15, 2024
| `video`s with an `src` will be rendered by our Video component, otherwise they'll render as stated. | ||
|
|
||
| <video src="https://interactive-examples.mdn.mozilla.net/media/cc0-videos/flower.webm" title="video" /> | ||
| `video`s with an `src` or a `source` video file will be rendered by our Video component, otherwise they'll render the original code. Videos with a `style` prop or another restricted prop will render their original code. |
There was a problem hiding this comment.
if removing the style prop works this will need to change
jakemhiller
approved these changes
Oct 15, 2024
dreamwasp
commented
Oct 15, 2024
| renderView({ text: table }); | ||
| expect(document.querySelectorAll('div.tableWrapper table').length).toEqual( | ||
| 1 | ||
| ); | ||
| }); | ||
|
|
||
| it('Skips rendering custom tables in markdown when skipProcessing.table is true', () => { | ||
| jest.spyOn(console, 'error').mockImplementation(jest.fn()); |
There was a problem hiding this comment.
tried a few different ways to format the Markdown here and it all errors, can come back to the tables later
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enables source tags from Video and filters out
videos with a style propPR Checklist
Testing Instructions
PR Links and Envs