Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start with empty lib #2952

Open
wants to merge 50 commits into
base: storybook-8
Choose a base branch
from
Open

start with empty lib #2952

wants to merge 50 commits into from
+5,112 −1,319

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 14, 2024 •
edited
Loading

Overview

I'm not gonna merge these down, just want 👀 before I mark the tickets as done~

Creates a blank storybook instance and fixes the deploy preview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [GM-836 + GM-837]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Check out the new PR instance!

PR Links and Envs

We will test these separately in GM-913

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 16, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 68140fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@dreamwasp dreamwasp marked this pull request as ready for review October 25, 2024 14:24
@dreamwasp dreamwasp requested a review from a team as a code owner October 25, 2024 14:24
@dreamwasp dreamwasp requested review from jakemhiller, BandanaKM and aresnik11 and removed request for a team October 25, 2024 14:24
jakemhiller
jakemhiller approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one failing test this LGTM!!!

@dreamwasp
Copy link
Contributor Author

Other than the one failing test this LGTM!!!

yeah, amy is fixing those on a another branch off of this one so i'll merge this down once those are ✅

BandanaKM
BandanaKM approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@BandanaKM BandanaKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, just the failing test!

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6723df3808b6752055228be8--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@BandanaKM BandanaKM BandanaKM approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamwasp @codecademydev @jakemhiller @BandanaKM