-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lexical editor integration #2940
base: main
Are you sure you want to change the base?
Conversation
|
package.json
Outdated
@@ -8,6 +8,7 @@ | |||
"@babel/core": "7.20.12", | |||
"@babel/preset-typescript": "^7.18.6", | |||
"@codecademy/eslint-config": "8.0.0", | |||
"@codecademy/gamut-kit": "^0.6.441", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gamut-kit is what is produced by these packages, so shouldn't be a dependency here
<Switch | ||
onClick={() => { | ||
if (isSplitScreen) { | ||
window.parent.location.href = `/${search}`; |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
user-provided value
export const uuid = Math.random() | ||
.toString(36) | ||
.replace(/[^a-z]+/g, '') | ||
.substr(0, 5); |
Check failure
Code scanning / CodeQL
Insecure randomness High
Math.random()
|
||
// Very primitive table setup | ||
const TABLE_ROW_REG_EXP = /^(?:\|)(.+)(?:\|)\s?$/; | ||
const TABLE_ROW_DIVIDER_REG_EXP = /^(\| ?:?-*:? ?)+\|\s?$/; |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
Overview
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs