feat(Flyout): Add as prop for Flyout title #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sooinc
changed the title
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
dreamwasp
reviewed
Sep 3, 2024
| @@ -72,7 +72,7 @@ export const Flyout: React.FC<FlyoutProps> = ({ | |||
| maxWidth="100%" | |||
| justifyContent="space-between" | |||
| > | |||
| <Text as="h2" fontSize={22}> | |||
| <Text as="h1" fontSize={22}> | |||
There was a problem hiding this comment.
do you think it makes sense for this to be configurable and default to h1?
There was a problem hiding this comment.
hmm i had that initially but i couldn't think of a case when title wont be the first in the heading level
There was a problem hiding this comment.
yeah that makes sense - we can swap to h1 and just refactor if there are any cases of it needing another title level
dreamwasp
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
asprop for Flyout title heading-levelPR Checklist
Testing Instructions
PR Links and Envs