Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Border Radius Token)!: Updating Molecules + Organism #2922

Merged
merged 4 commits into from
Aug 6, 2024
Merged

feat(Border Radius Token)!: Updating Molecules + Organism #2922

merged 4 commits into from
Aug 6, 2024

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Aug 6, 2024 •
edited by jira bot
Loading

Overview

Updating molecules + Organism
See Notion for more details (https://www.notion.so/codecademy/Border-Radius-Tracker-55c1c9e9ab49480995d314ac3fb784ff)

This one was more straightforward

PR Checklist

  • Related to designs:
  • Related to a mixture of JIRA tickets: GM-592, GM-892, GM-828, GM-830
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Check out the

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@LinKCoding LinKCoding changed the base branch from main to kl-gm-592 August 6, 2024 03:16
@LinKCoding LinKCoding marked this pull request as ready for review August 6, 2024 13:14
@LinKCoding LinKCoding requested a review from a team as a code owner August 6, 2024 13:14
@LinKCoding LinKCoding requested review from jakemhiller, timjenkins and dreamwasp and removed request for a team August 6, 2024 13:14
@jira jira bot mentioned this pull request Aug 6, 2024
Merged
6 tasks
dreamwasp
dreamwasp reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chefs kiss:

@LinKCoding LinKCoding merged commit 976edaa into kl-gm-592 Aug 6, 2024
4 of 11 checks passed
@LinKCoding LinKCoding deleted the kl-gm-592-molecules-organisms branch August 6, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp left review comments

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller was automatically assigned from Codecademy/gamut

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins was automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinKCoding @dreamwasp