Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Radio): add infotip type to radio fields #2905

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix(Radio): add infotip type to radio fields #2905

merged 2 commits into from
Jul 8, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jul 3, 2024 •
edited
Loading

Overview

Fixes the radio-type for the new infotip prop

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [gm-763]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Go to GridForm Page
  • Gridform should render
  • Go to this PR
  • See all the tests pass 🔥

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://668564772197d52e4054b159--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp marked this pull request as ready for review July 8, 2024 15:10
@dreamwasp dreamwasp requested a review from a team as a code owner July 8, 2024 15:10
timjenkins
timjenkins approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@timjenkins timjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Jul 8, 2024
@codecademydev codecademydev merged commit 19cb620 into main Jul 8, 2024
21 of 22 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jul 8, 2024
@codecademydev codecademydev deleted the cass-gm-763-typescheck branch July 8, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjenkins timjenkins timjenkins approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@LinKCoding LinKCoding Awaiting requested review from LinKCoding LinKCoding is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @timjenkins