Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Alert): height and alignment #2903

Merged
merged 3 commits into from
Jul 8, 2024
Merged

fix(Alert): height and alignment #2903

merged 3 commits into from
Jul 8, 2024

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Jul 1, 2024

Overview

Two Issues:

  1. The Alert's alignments were off (not centered and stretched out):
    The alignment Alert wasn't rendering properly because the alert was stretched vertically.
    Upon investigation, it was the X button that had a large height, despite the button seemingly set to "small"
    Looking into IconButton, seems like the size prop wasn't used, adding this prop back in seemed to fix the issue.

  2. The border radius of both inline and general alerts should be 3px.

PR Checklist

Testing Instructions

  1. Go to /docs/molecules-alert--usage-guidelines#alert-types
  2. Check that the height alignment matches figma

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@LinKCoding LinKCoding marked this pull request as ready for review July 1, 2024 20:55
@LinKCoding LinKCoding requested a review from a team as a code owner July 1, 2024 20:55
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://668c48fbb43fe1b048e8c9e0--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Jul 8, 2024
@codecademydev codecademydev merged commit fae2fb7 into main Jul 8, 2024
17 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jul 8, 2024
@codecademydev codecademydev deleted the kl-alert-fix branch July 8, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants