Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IconButton): aria-describedby override #2894

Merged
merged 11 commits into from
Jun 26, 2024
Merged

feat(IconButton): aria-describedby override #2894

merged 11 commits into from
Jun 26, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jun 26, 2024 •
edited
Loading

Overview

Add override to have IconButton tip optionally not be split into aria-label and described-by (non-breaking)

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [gm-788]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Go to ToolTip page and see new example.
  • On VO new and old examples should correctly announce their tip text.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@dreamwasp dreamwasp marked this pull request as ready for review June 26, 2024 19:03
@dreamwasp dreamwasp requested a review from a team as a code owner June 26, 2024 19:04
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://667c683b655c302ac2976e9f--gamut-preview.netlify.app

Deploy Logs

LinKCoding
LinKCoding approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well!

@dreamwasp dreamwasp added Ship It :shipit: Automerge this PR when possible and removed Ship It :shipit: Automerge this PR when possible labels Jun 26, 2024
@codecademydev codecademydev merged commit ca12c0b into main Jun 26, 2024
21 of 24 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jun 26, 2024
@codecademydev codecademydev deleted the cass-iconbutton-qf branch June 26, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @LinKCoding