docs(Icon): updating documentation #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinKCoding
changed the title
LinKCoding
commented
Jul 9, 2024
| @@ -26,6 +26,14 @@ import { | |||
| args={{}} | |||
| /> | |||
|
|
|||
| ## General Infomation | |||
|
|
|||
| For mini icons, we use a subset of [Streamline's "Core Solid" icons](https://www.streamlinehq.com/icons/core-solid). | |||
There was a problem hiding this comment.
Check with Stacey if this link is ok
LinKCoding
commented
Jul 9, 2024
| @@ -46,25 +46,12 @@ import { | |||
|
|
|||
| ## General Infomation | |||
|
|
|||
| We use a subset of [streamline icons](https://app.streamlineicons.com/streamline-regular), mainly the Outline version of the Regular set. | |||
| For regular icons, we use a subset of [Streamline's "Ultimate Regular" icons](https://www.streamlinehq.com/icons/streamline-regular). | |||
There was a problem hiding this comment.
Check with Stacey if this link is ok (and removal of the clause is ok) seems like Regular don't use Outline? or shouldn't?
aresnik11
reviewed
Jul 9, 2024
aresnik11
reviewed
Jul 9, 2024
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reorganizes documentation for icon creation in storybook
Updating Icon documentation
PR Checklist
Testing Instructions
Don't make me tap the sign.