feat(Disclosure): creating an Disclosure component #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinKCoding
changed the title
dreamwasp
reviewed
Jun 7, 2024
packages/styleguide/stories/Molecules/Disclosure/index.stories.mdx
Outdated
Show resolved
Hide resolved
|
Going to leave this PR in limbo for the time being since we need to work on refactoring list/expandedrow to accommodate Disclosure. However, all styling and feedback is addressed and should be reviewed. |
dreamwasp
reviewed
Jun 13, 2024
dreamwasp
reviewed
Jun 21, 2024
| expanded: { height: 'auto' }, | ||
| collapsed: { height: 0 }, | ||
| }} | ||
| transition={{ duration: 0.5, ease: 'easeInOut' }} |
There was a problem hiding this comment.
this seems a little slow - you could double check with stacey but i think we'd want it to match List (0.2, or timingValues.medium / 1000 if you wanna be fancy!)
| @@ -0,0 +1,23 @@ | |||
| import { motion } from 'framer-motion'; | |||
|
|
|||
There was a problem hiding this comment.
love this!!! starting to think we need more gamut documentation on our animations (not in this PR but maybe another ticket for the backlog ✨ )
There was a problem hiding this comment.
Ah, you're right -- I'll cut a ticket!
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding a Disclosure component to replace the current AccordionDeprecated component.
PR Checklist
Testing Instructions
path=/docs/molecules-disclosure--disclosure(Mono)
admin/portal(Monolith)
Don't make me tap the sign.
PR Links and Envs