Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icons): Add DiscordIcon and GaugeDashboardIcon #2857

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

sooinc
Copy link
Contributor

@sooinc sooinc commented Apr 8, 2024

Overview

  • add regular DiscordIcon in the vender section
  • add regular GaugeDashboardIcon

PR Checklist

Testing Instructions

  1. check GaugeDashboardIcon in the regular section: https://661596f67c08950933ce6e9a--gamut-preview.netlify.app/?path=/docs/atoms-icons-regular--editable-icon
  2. check DiscordIcon in the vendor section: https://661596f67c08950933ce6e9a--gamut-preview.netlify.app/?path=/docs/atoms-icons-regular--editable-icon

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Portal Env

@sooinc sooinc changed the title feat(icons): Add discord and gauge icons feat(icons): Add Discord and GaugeDashboard icons Apr 9, 2024
@sooinc sooinc changed the title feat(icons): Add Discord and GaugeDashboard icons feat(Icons): Add DiscordIcon and GaugeDashboardIcon Apr 9, 2024
@sooinc sooinc marked this pull request as ready for review April 9, 2024 21:58
@sooinc sooinc requested a review from a team as a code owner April 9, 2024 21:58
@LinKCoding
Copy link
Contributor

LinKCoding commented Apr 10, 2024

@sooinc would you also need to export the dashboard icon in stories? I only see the discord icon exported

@sooinc
Copy link
Contributor Author

sooinc commented Apr 10, 2024

@sooinc would you also need to export the dashboard icon in stories? I only see the discord icon exported

i dont think so - happens automagically. you can see the gaugeDashboardIcon added in storybook without having to export it separately. for the discord icon, we have to specify in the const so that it shows up in the "vendor" section.
Screenshot 2024-04-10 at 5 34 52 PM

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66170ba6d990b65b2fb9382e--gamut-preview.netlify.app

Deploy Logs

@sooinc sooinc added the Ship It :shipit: Automerge this PR when possible label Apr 11, 2024
@codecademydev codecademydev merged commit 075e370 into main Apr 11, 2024
18 of 19 checks passed
@codecademydev codecademydev deleted the sc-add-icons branch April 11, 2024 14:04
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants