Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): list story #2856

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix(storybook): list story #2856

merged 5 commits into from
Apr 12, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Apr 8, 2024 •
edited
Loading

Overview

Fixes breaking List story and some lint thinga

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

PR Links and Envs

Storybook only change, List story should load

@dreamwasp dreamwasp marked this pull request as ready for review April 8, 2024 20:19
@dreamwasp dreamwasp requested a review from a team as a code owner April 8, 2024 20:19
jakemhiller
jakemhiller approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@LinKCoding
Copy link
Contributor

I would be curious why there was a need to remove colormode (i.e. replace it with background) but it works and looks good!

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://661801408b99842dd0016c88--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Apr 12, 2024
@codecademydev codecademydev merged commit 511fc72 into main Apr 12, 2024
18 of 19 checks passed
@codecademydev codecademydev deleted the cass-list-fix branch April 12, 2024 18:36
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@LinKCoding LinKCoding Awaiting requested review from LinKCoding LinKCoding is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamwasp @LinKCoding @codecademydev @jakemhiller