fix(HiddenText): updated status to deprecated #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinKCoding
changed the title
aresnik11
approved these changes
Apr 2, 2024
jakemhiller
reviewed
Apr 2, 2024
| Ideally those cases should be exceedingly rare; unfortunately, some of our older pages aren't set up well for this. | ||
|
|
||
| For newer pages, use [`<Text>` component](https://gamut.codecademy.com/iframe.html?id=typography-text--screenreader&viewMode=docs#highlight) and set `screenreader="true"`. |
There was a problem hiding this comment.
should we add @ deprecated to the typescript comment above the HiddenText component?
There was a problem hiding this comment.
That way it will show up as deprecated when it is used. We could also update the comment to include some of these instructions
|
🚀 Styleguide deploy preview ready! |
📬Published Alpha Packages:@codecademy/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is to mark
<HiddenText>as deprecated.Also to update some confusing screenreader text.
This should only affect Gamut and no other repos
PR Checklist
Testing Instructions
Visit the
<HiddenText>(/?path=/docs/typography-hiddentext--hidden-text) component and see the notice that the status is now "deprecated".Also Text (/?path=/docs/typography-text--text) and see that the
screenreaderexample now shows less confusing visible text AND when inspecting that the text visible to screenreaders also make more sense.PR Links and Envs