Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Determine Card boxShadow based on colorMode #2846

Closed
wants to merge 5 commits into from
Closed

Fix: Determine Card boxShadow based on colorMode #2846

wants to merge 5 commits into from

Conversation

j10sanders
Copy link
Contributor

Overview

Cards on top of dark backgrounds with a boxShadow were not displaying well on dark backgrounds, because the shadow was always dark. This fixes that.

Screen.Recording.2024-03-15.at.12.11.03.PM.mov

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: DOT-102
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Will have to do QA on various cards throughout :(

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@j10sanders j10sanders changed the title Determine Card boxShadow based on colorMode Fix: Determine Card boxShadow based on colorMode Mar 15, 2024
@dreamwasp
Copy link
Contributor

there's alot of unintended changes on this branch - not sure why the compiled types are being picked up by git. i'm looking into it now

dreamwasp
dreamwasp requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this for now while i figure out the unintended changes

@j10sanders
Copy link
Contributor Author

blocking this for now while i figure out the unintended changes

woah! I don't think the vscode setting.json would do it but I'll remove that change just in case

@j10sanders
Copy link
Contributor Author

j10sanders commented Mar 15, 2024 •
edited
Loading

It added these three directories:

packages/gamut-labs/
packages/markdown-overrides/
packages/monaco/

Should I just try a new branch with the single file changes?

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65f4c07c846e7c33bea4210c--gamut-preview.netlify.app

Deploy Logs

@j10sanders j10sanders mentioned this pull request Mar 15, 2024
Merged
@j10sanders
Copy link
Contributor Author

@dreamwasp trying again here #2846

@j10sanders j10sanders closed this Mar 15, 2024
codecademydev pushed a commit that referenced this pull request Mar 29, 2024
@j10sanders
fix: Color Mode BoxShadow for cards
bd84e2b 
Redoing #2846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j10sanders @dreamwasp @codecademydev