Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused packages #2760

Merged
merged 3 commits into from
Jul 24, 2023
Merged

chore: Remove unused packages #2760

merged 3 commits into from
Jul 24, 2023

Conversation

jakemhiller
Copy link
Member

Overview

Remove unused @codecademy/markdown-overrides and @codecademy/monaco packages

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@jakemhiller jakemhiller requested a review from a team as a code owner July 24, 2023 15:50
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://64bea01535c74f0f0169c52b--gamut-preview.netlify.app

Deploy Logs

@jakemhiller jakemhiller changed the title Jh rm unused packages chore: Remove unused packages Jul 24, 2023
dreamwasp
dreamwasp approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

@jakemhiller jakemhiller added the Ship It :shipit: Automerge this PR when possible label Jul 24, 2023
@codecademydev codecademydev merged commit 23d8657 into main Jul 24, 2023
14 of 17 checks passed
@codecademydev codecademydev deleted the jh-rm-unused-packages branch July 24, 2023 17:24
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakemhiller @codecademydev @dreamwasp