feat(Illustrations): Add 3 new onboarding quiz illustrations #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippyzow
requested review from
a team,
saghdaey and
cstatro
and removed request for
a team
saghdaey
reviewed
Jul 20, 2023
|
|
||
| import { IllustrationProps } from './types'; | ||
|
|
||
| export const Goal: React.FC<IllustrationProps> = ({ |
There was a problem hiding this comment.
non-blocking and just a question, should we call this one purpose instead of goal so it matches the id of that question?
the other two are a little closer tied together
saghdaey
approved these changes
Jul 20, 2023
medhatnar
approved these changes
Jul 20, 2023
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add 3 new illustrations for our revamp of the onboarding quiz.
PR Checklist
Testing Instructions
Storybook: Under Illustrations, see
GoalPurpose, Interest, and Knowledge.Mono PR Env: As a logged in user navigate to the onboarding quiz
/welcome/find-a-course. See appropriate image and text next to each question. Details of implementation/axe will be addressed in separate mono ticket. This is just to make sure the images are being imported from Gamut ok.PR Links and Envs