HP-2655 | fix: uwsgi has version mismatches with precompiled python libs #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #315 +/- ##
========================================
Coverage 80.48% 80.48%
========================================
Files 91 91
Lines 3843 3843
========================================
Hits 3093 3093
Misses 750 750 ☔ View full report in Codecov by Sentry. |
Disable ssl for uwsgi. Refs: HP-2655
lxml and xmlsec were installed as prebuilt python wheels. This caused version mismatch with uwsgi which was built against xmlsec1 and libxml2 libraries installed in the Dockerfile. lxml and xmlsec will now be compiled against the same libraries as uwsgi to avoid version mismatch issue. Refs: HP-2655
charn
force-pushed
the
HP-2655-fix-version-mismatch
branch
from
8311575
to
113ce3e
Compare
|
voneiden
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using libxml2 we can use expat with uwsgi which avoids the version mismatch with precompiled python libraries.
Also ssl is not terminated by uwsgi, so the feature can be disabled.
Refs: HP-2655