Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable harrastushaku fuzzy keyword search #657

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

voneiden
Copy link
Contributor

Full text search + trigram similarity can result in inappropriate keywords to be selected in events.

https://helsinkisolutionoffice.atlassian.net/browse/LINK-1420

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #657 (d055170) into develop (434dd30) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #657      +/-   ##
===========================================
+ Coverage    76.09%   76.13%   +0.03%     
===========================================
  Files          239      239              
  Lines        17364    17354      -10     
===========================================
- Hits         13214    13213       -1     
+ Misses        4150     4141       -9     
Files Changed Coverage Δ
events/importer/harrastushaku.py 31.47% <0.00%> (+0.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@voneiden voneiden requested a review from a team August 14, 2023 12:57
@voneiden voneiden marked this pull request as ready for review August 14, 2023 12:57
Full text search + trigram similarity can result in inappropriate
keywords to be selected in events.
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@tuomas777 tuomas777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@voneiden voneiden merged commit 0450098 into develop Aug 15, 2023
3 checks passed
@voneiden voneiden deleted the link-1420-no-fuzzy-keyword branch August 15, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants