Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yso:p16596 tourists keywod to helsinki:audiences #656

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add yso:p16596 tourists keywod to helsinki:audiences #656

merged 1 commit into from
Aug 14, 2023

Conversation

voneiden
Copy link
Contributor

@voneiden voneiden commented Aug 14, 2023 •
edited
Loading

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #656 (d0a9518) into develop (a1ad53f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #656      +/-   ##
===========================================
- Coverage    76.10%   76.09%   -0.01%     
===========================================
  Files          239      239              
  Lines        17363    17364       +1     
===========================================
  Hits         13214    13214              
- Misses        4149     4150       +1
Files Changed Coverage Δ
...vents/management/commands/add_helsinki_audience.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@voneiden voneiden marked this pull request as ready for review August 14, 2023 08:19
@voneiden voneiden requested a review from a team August 14, 2023 08:20
charn
charn approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@charn charn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 🚢

@voneiden voneiden merged commit 434dd30 into develop Aug 14, 2023
3 checks passed
@voneiden voneiden deleted the link-1377-matkailu branch August 14, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charn charn charn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voneiden @codecov-commenter @charn