Delete events not found in Elis in kulke importer #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #625 +/- ##
===========================================
+ Coverage 74.52% 75.31% +0.78%
===========================================
Files 237 237
Lines 17074 17178 +104
===========================================
+ Hits 12725 12937 +212
+ Misses 4349 4241 -108
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
danipran
previously requested changes
Jul 3, 2023
danipran
force-pushed
the
kulke-deletion
branch
2 times, most recently
from
30493e1
to
5fc016f
Compare
charn
reviewed
Jul 26, 2023
charn
reviewed
Jul 26, 2023
charn
approved these changes
Jul 26, 2023
A minor comment about testing those soft deleted events.
|
Kudos, SonarCloud Quality Gate passed! |
danipran
dismissed
their stale review
Ended up doing the changes myself, so approving my own changes isn't exactly cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are events that have previously been imported, but have since been removed in Elis, there's currently no mechanism to remove them from LE. This PR adds such a mechanism. Basically we check for any events that we have previously imported that no longer exist in Elis. We won't touch events that are older than the start date we use for the Elis search though.
Also, the fix for the empty name issue in my previous PR was not sufficient, so I fixed that. The logic for taking the common part when creating a super event name should now work in all supported languages.
When reviewing, please pay special attention to the logic for selecting which events to delete.