LINK-2203 | fix(events): use django qs functions in max_* and min_duration filters #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1007.api.dev.hel.ninja 🚀🚀🚀 |
nicobav
force-pushed
the
LINK-2203/max-dur-hide-rec-err
branch
from
9a65116
to
b657d02
Compare
danipran
approved these changes
Oct 31, 2024
There were 'ProgrammingError' thrown when using max or min_duration filter with hide_recurring_children filter. This was because the *_duration filters were defined to use custom sql WHERE clauses without referring to which table the fields in the WHERE clause was referring to and there were other tables joined to the query by hide_recurring_ children filter. Solution was to convert these max and min_duration filters to be using django qs functions. Also refactors the max_ and min_duration filters away from api.py to filters. Refs LINK-2203
nicobav
force-pushed
the
LINK-2203/max-dur-hide-rec-err
branch
from
b657d02
to
a41cee0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were
ProgrammingErrorthrown when usingmaxormin_durationfilter withhide_recurring_childrenfilter. This was because themin_*andmax_durationfilters were defined to use custom sqlWHEREclauses without referring to which table the fields in theWHEREclause was referring to and there were other tables joined to the query byhide_recurring_childrenfilter.Solution was to convert these max and min_duration filters to be using django qs functions.
Also refactors the
max_andmin_durationfilters away fromapi.pyto filters.Refs LINK-2203