Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI Fix for githooks #415

Merged
merged 1 commit into from
Sep 8, 2023
Merged

HAI Fix for githooks #415

merged 1 commit into from
Sep 8, 2023

Conversation

corvidian
Copy link
Contributor

@corvidian corvidian commented Sep 7, 2023

Description

There was an issue with the shebang line, it didn't work for everyone unless it said bash instead of sh. While at it, add some robustness to bash commands and a bit more logging and documentation.

Jira Issue:

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

Please describe tests how this change or new feature can be tested.

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

Other relevant info

Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@corvidian corvidian marked this pull request as ready for review September 7, 2023 12:45
@corvidian corvidian merged commit c915dd6 into dev Sep 8, 2023
4 checks passed
@corvidian corvidian deleted the HAI/githook-fix branch September 8, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants