Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI-1844: Create hankekayttaja instance for Hanke perustaja #390

Merged
merged 13 commits into from
Aug 31, 2023

Conversation

pitkni
Copy link
Contributor

@pitkni pitkni commented Aug 18, 2023

Description

Add functionality to include Hanke perustaja in hanke kayttaja listing. Hanke perustaja is now mandatory information in Hanke creation. The not-null requirement is enforced in the database also. Existing entries will have empty string for name and email.

A hanke generated from a cable report is a special case. In these cases perustaja is generated from the ordered person in application contacts.

Additional: permission for hanke creator is now set in the service layer as the permission entity is required for token creation.

Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-1844

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

  "kayttajat": [
    {
      "id": "51e03361-d313-4093-a365-172f0a2817ac",
      "sahkoposti": "[email protected]",
      "nimi": "Matti Meikäläinen",
      "rooli": "KAIKKI_OIKEUDET",
      "tunnistautunut": true
    }
  ]
}

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

Other relevant info

Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

@pitkni pitkni force-pushed the HAI-1844/token-hankekayttaja-perustaja branch 5 times, most recently from 9900738 to 5ccb892 Compare August 21, 2023 06:36
@pitkni pitkni marked this pull request as ready for review August 21, 2023 06:42
@pitkni pitkni force-pushed the HAI-1844/token-hankekayttaja-perustaja branch from 726fbd5 to 4aae699 Compare August 21, 2023 11:29
Add functionality to include Hanke perustaja in hanke kayttaja listing. Hanke perustaja is now mandatory information in Hanke creation.

A hanke generated from a cable report is a special case. In these cases perustaja is generated from the ordered person in application contacts.
@pitkni pitkni force-pushed the HAI-1844/token-hankekayttaja-perustaja branch from 87358f4 to 6d2b476 Compare August 23, 2023 13:21
Base automatically changed from dev to main August 24, 2023 11:57
@corvidian corvidian changed the base branch from main to dev August 24, 2023 13:48
…n accordingly, improve authorisation check in controller
@pitkni pitkni force-pushed the HAI-1844/token-hankekayttaja-perustaja branch from 03f25ec to 9b89c02 Compare August 30, 2023 17:15
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.6% 95.6% Coverage
0.0% 0.0% Duplication

@pitkni pitkni merged commit 8e4ece4 into dev Aug 31, 2023
4 checks passed
@pitkni pitkni deleted the HAI-1844/token-hankekayttaja-perustaja branch August 31, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants