-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HAI-1844: Create hankekayttaja instance for Hanke perustaja #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitkni
force-pushed
the
HAI-1844/token-hankekayttaja-perustaja
branch
5 times, most recently
from
August 21, 2023 06:36
9900738
to
5ccb892
Compare
corvidian
reviewed
Aug 21, 2023
services/hanke-service/src/main/kotlin/fi/hel/haitaton/hanke/HankeServiceImpl.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 21, 2023
services/hanke-service/src/main/kotlin/fi/hel/haitaton/hanke/domain/Hanke.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 21, 2023
...vice/src/main/resources/db/changelog/changesets/043-change-hanke-perustaja-non-nullable.yaml
Outdated
Show resolved
Hide resolved
pitkni
force-pushed
the
HAI-1844/token-hankekayttaja-perustaja
branch
from
August 21, 2023 11:29
726fbd5
to
4aae699
Compare
Add functionality to include Hanke perustaja in hanke kayttaja listing. Hanke perustaja is now mandatory information in Hanke creation. A hanke generated from a cable report is a special case. In these cases perustaja is generated from the ordered person in application contacts.
…lidate create request
pitkni
force-pushed
the
HAI-1844/token-hankekayttaja-perustaja
branch
from
August 23, 2023 13:21
87358f4
to
6d2b476
Compare
corvidian
reviewed
Aug 29, 2023
services/hanke-service/src/main/kotlin/fi/hel/haitaton/hanke/HankeServiceImpl.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 29, 2023
...ices/hanke-service/src/main/kotlin/fi/hel/haitaton/hanke/permissions/HankeKayttajaService.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 29, 2023
services/hanke-service/src/main/kotlin/fi/hel/haitaton/hanke/HankeServiceImpl.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 29, 2023
services/hanke-service/src/integrationTest/kotlin/fi/hel/haitaton/hanke/HankeServiceITests.kt
Show resolved
Hide resolved
corvidian
reviewed
Aug 29, 2023
services/hanke-service/src/test/kotlin/fi/hel/haitaton/hanke/factory/HankeFactory.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 30, 2023
...rvice/src/integrationTest/kotlin/fi/hel/haitaton/hanke/permissions/PermissionServiceITest.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 30, 2023
...rvice/src/integrationTest/kotlin/fi/hel/haitaton/hanke/permissions/PermissionServiceITest.kt
Outdated
Show resolved
Hide resolved
…n accordingly, improve authorisation check in controller
corvidian
reviewed
Aug 30, 2023
services/hanke-service/src/main/kotlin/fi/hel/haitaton/hanke/HankeController.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 30, 2023
services/hanke-service/src/main/kotlin/fi/hel/haitaton/hanke/HankeServiceImpl.kt
Outdated
Show resolved
Hide resolved
corvidian
reviewed
Aug 30, 2023
...ices/hanke-service/src/main/kotlin/fi/hel/haitaton/hanke/permissions/HankeKayttajaService.kt
Outdated
Show resolved
Hide resolved
…ndant check in update validation
pitkni
force-pushed
the
HAI-1844/token-hankekayttaja-perustaja
branch
from
August 30, 2023 17:15
03f25ec
to
9b89c02
Compare
Kudos, SonarCloud Quality Gate passed! |
corvidian
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functionality to include Hanke perustaja in hanke kayttaja listing. Hanke perustaja is now mandatory information in Hanke creation. The not-null requirement is enforced in the database also. Existing entries will have empty string for name and email.
A hanke generated from a cable report is a special case. In these cases perustaja is generated from the ordered person in application contacts.
Additional: permission for hanke creator is now set in the service layer as the permission entity is required for token creation.
Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-1844
Type of change
Instructions for testing
Checklist:
or other location:
Other relevant info
Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.