Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code organization and test refinements #27

Merged
merged 14 commits into from
Dec 18, 2023
Merged

Code organization and test refinements #27

merged 14 commits into from
Dec 18, 2023

Conversation

Starttoaster
Copy link
Contributor

@Starttoaster Starttoaster commented Dec 17, 2023

This PR:

  • Reorganizes all of the controller logic code into different packages to make the API/controllers easier to build and maintain. Changed files in internal/controller/**.
  • Adds contribution rules surrounding API struct fields. Changed CONTRIBUTING.md.
  • Changes the API to follow these contributing guidelines; controller logic updated to adopt the new API without actual usage changes. Changed files in api/ and internal/controller.
  • Adds substantial testing to controller logic and API struct unmarshaling from yaml. Changes files like api/v1/*_test.go and internal/controller/*_test.go.
  • Adds a config toggle to disable (defaults to enable) a chia-exporter sidecar container for all chia deployments/statefulsets. No functionality change, this was previously hardcoded to enabled, it just adds a provision to turn it off.
  • Adds documentation for each of the custom resources in this operator. Adds files in docs/
  • Fixes bug with mounting persistent volumes in multiple services.

@Starttoaster Starttoaster marked this pull request as draft December 17, 2023 04:53
@Starttoaster Starttoaster marked this pull request as ready for review December 17, 2023 18:50
@Starttoaster Starttoaster merged commit 7c1334d into main Dec 18, 2023
8 checks passed
@Starttoaster Starttoaster deleted the reorg branch December 18, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants